Skip to content

[action] [PR:21624] Fix buffer configs for TH5 C224 SKU#607

Merged
mssonicbld merged 1 commit intoAzure:202412from
mssonicbld:cherry/msft-202412/21624
Feb 12, 2025
Merged

[action] [PR:21624] Fix buffer configs for TH5 C224 SKU#607
mssonicbld merged 1 commit intoAzure:202412from
mssonicbld:cherry/msft-202412/21624

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Why I did it

The values in this config were found to be incorrect when testing. With fewer interfaces than the C256, the reserved buffer space is smaller and therefore the shared limit in this config must be smaller.

The BUFFER_QUEUE macro was also not present, causing the defaults to be used which referenced lossless profiles.

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

<!--
     Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

     ** Make sure all your commits include a signature generated with `git commit -s` **

     If this is a bug fix, make sure your description includes "fixes #xxxx", or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it

The values in this config were found to be incorrect when testing. With fewer interfaces than the C256, the reserved buffer space is smaller and therefore the shared limit in this config must be smaller.

The BUFFER_QUEUE macro was also not present, causing the defaults to be used which referenced lossless profiles.

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it

#### How to verify it

<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211
- [ ] 202305

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
 Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: sonic-net/sonic-buildimage#21624

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang sdszhang enabled auto-merge February 12, 2025 12:36
@mssonicbld mssonicbld merged commit 2ab6278 into Azure:202412 Feb 12, 2025
4 of 10 checks passed
bingwang-ms pushed a commit that referenced this pull request Jan 16, 2026
…D automatically (#23160)

#### Why I did it
src/sonic-platform-daemons
```
* 700ccd4 - (HEAD -> master, origin/master, origin/HEAD) Catch the xcvrd exception returned by get_transceiver_info (#632) (7 hours ago) [Ariz Zubair]
* 4ab0238 - Chassisd does not wait for the execution to complete for previous admin state change requests. Fixed issue #22138 (#607) (11 hours ago) [rameshraghupathy]
```
#### How I did it
#### How to verify it
#### Description for the changelog
bingwang-ms pushed a commit that referenced this pull request Jan 16, 2026
… automatically (#23672)

#### Why I did it
src/sonic-platform-common
```
* 9314538 - (HEAD -> master, origin/master, origin/HEAD) [Smartswitch] Host container differentiation for sensor commands (#604) (6 days ago) [Gagan Punathil Ellath]
* 6a3f0d6 - Add new liquid cooling base object (#603) (6 days ago) [Yuanzhe]
* a615dbc - [sonic-platform-common] Build failure with "ModuleNotFoundError: No module named 'sonic_platform_base.sonic_xcvr.cdb'" (#607) (10 days ago) [mihirpat1]
* ef6ee2b - Update Host and single media interfaces IDs per SFF-8024 v4.13 (#596) (5 weeks ago) [mihirpat1]
* 1ccb062 - Adding 800G-ZR codes and ability to check 150GHz grid spacing (#601) (6 weeks ago) [Aditya]
* 47be7af - Update MODULE_FAULT_CAUSE with additional codes (4-6) (#597) (6 weeks ago) [infn-ke]
* 320c11b - Add is_lpo API (#599) (6 weeks ago) [longhuan-cisco]
* 2bcbe3a - Fix health check for SSD vendors: add a parser for ATP, and add a generic health ID for other brands (#595) (8 weeks ago) [Mark Xiao]
* 499d775 - lock sensord restart (#594) (8 weeks ago) [Gagan Punathil Ellath]
* aa32bef - CDB Refactor (#584) (3 months ago) [Prince George]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant